fix(ui): replace Popover with Tooltip on disabled Register model button to fix focus trap#2817
Open
Philip-Carneiro wants to merge 1 commit into
Open
Conversation
Signed-off-by: Philip Colares Carneiro <philip.colares@gmail.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/retest |
8 tasks
manaswinidas
suggested changes
Jun 12, 2026
| cy.findAllByText('N/A').should('have.length.at.least', 1); | ||
| }); | ||
|
|
||
| it('should show disabled register button with tooltip when no model registries exist', () => { |
Contributor
There was a problem hiding this comment.
can we add a cy.testA11y() to double check all accessibility violations are gone?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an accessibility (a11y) regression on the Model Catalog Details page where keyboard focus (Tab) gets trapped on the disabled "Register model" button.
Root cause: The
Popovercomponent withtriggerAction="hover"combined withisAriaDisabledon the button causes PatternFly's internal focus management to trap the Tab cycle, preventing users from navigating past the button.Fix: Replace
PopoverwithTooltipfor the disabled "Register model" button. TheTooltipprovides the same hover information without interfering with keyboard focus management. ThePopoverused for the "Validated" label is unaffected and remains unchanged.Before
Screen.Recording.2026-06-11.at.14.23.19.mov
After
Screen.Recording.2026-06-11.at.14.21.44.mov
How Has This Been Tested?
It was manually tested as the video sample and added tests in cypress for it
Merge criteria:
DCOcheck)ok-to-testhas been added to the PR.If you have UI changes